-
-
Notifications
You must be signed in to change notification settings - Fork 32.9k
gh-135953: Reduce memory usage of stack collectors #138875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eb1bffb
to
a89c852
Compare
Amazing! I have pushed a commit adding an initial version of the string table for the flame graph. We can improve that in subsequent PRs |
Will fix merge conflicts tomorrow |
The stack collector base class keeps all frames until export() is called, which causes significant unnecessary memory usage. Instead, we can process the frames on the fly in the collect call by dispatching the aggregation logic to the subclass through the process_frames method.
a89c852
to
52c9867
Compare
|
The stack collector base class keeps all frames until export() is called, which causes significant unnecessary memory usage. Instead, we can process the frames on the fly in the collect call by dispatching the aggregation logic to the subclass through the process_frames method.