Make sure :keyword: role works for case
#138878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting core review
docs
sobolevn
added
skip issue
needs backport to 3.13
|
Looks like that it is correct now: :keyword:`case` generates https://cpython-previews--138878.org.readthedocs.build/en/138878/reference/compound_stmts.html#case as a link. And it generates this HTML: <span id="case"></span>
<span id="match"></span>
So, I am reverting the test change :) |
AA-Turner
approved these changes
Sep 21, 2025
|
Thanks @sobolevn for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2025
(cherry picked from commit 848d926) Co-authored-by: sobolevn <mail@sobolevn.me>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2025
(cherry picked from commit 848d926) Co-authored-by: sobolevn <mail@sobolevn.me>
|
GH-139200 is a backport of this pull request to the 3.14 branch. |
|
GH-139201 is a backport of this pull request to the 3.13 branch. |
AA-Turner
pushed a commit
that referenced
this pull request
Sep 21, 2025
hugovk
pushed a commit
that referenced
this pull request
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot to @AA-Turner for help.
I decided not to change the heading, because it can be a part of the existing links: https://docs.python.org/3/reference/compound_stmts.html#the-match-statement And we can break it.
I also added a quick test for
:keyword:case, let's see :)📚 Documentation preview 📚: https://cpython-previews--138878.org.readthedocs.build/