Skip to content

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Sep 14, 2025

@StanFromIreland StanFromIreland marked this pull request as ready for review September 15, 2025 06:53
@ambv
Copy link
Contributor

ambv commented Sep 16, 2025

Great idea, love it. In fact, you can use the pager always since it's deliberately a rather independent part of PyREPL. pydoc is using it, too (the code was moved from there originally)

@picnixz
Copy link
Member

picnixz commented Sep 16, 2025

In fact, you can use the pager always since it's deliberately a rather independent part of PyREPL

Would it be possible to isolate it outside _pyrepl? (would it also make sense?) Since we have _colorize for colorization support, _pypager.py would make sense (I would suggest the _py prefix to be sure we don't shadow _pager.py modules from users)

@ambv
Copy link
Contributor

ambv commented Sep 16, 2025

Would it be possible to isolate it outside _pyrepl?

Yes, I moved it out of pydoc mostly to be able to type-annotate it, change the API a bit, and make it fully independent of pydoc. I didn't want to make up a top-level module name at the time, but if it makes sense, we can do that.

@StanFromIreland
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants