Skip to content

gh-136003: Skip non-daemon threads when exceptions occur during finalization #139129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2025
Merged

gh-136003: Skip non-daemon threads when exceptions occur during finalization #139129

merged 4 commits into from
Sep 18, 2025

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Sep 18, 2025 •
edited by bedevere-app bot
Loading

During finalization, we need to mark all non-daemon threads as daemon to quickly shut down threads when sending CTRL^C to the process. This was a minor regression from GH-136004.

@bedevere-app bedevere-app bot mentioned this pull request Sep 18, 2025
Closed
ericsnowcurrently
ericsnowcurrently approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm still not convinced changing the whence after the fact is good long term but we can address that separately.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Sprint 2024 Sep 18, 2025
@ZeroIntensity ZeroIntensity merged commit 3eec897 into python:main Sep 18, 2025
47 checks passed
@ZeroIntensity ZeroIntensity deleted the fix-threading-interrupt branch September 18, 2025 20:04
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sprint 2024 Sep 18, 2025
@ZeroIntensity ZeroIntensity mentioned this pull request Oct 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
skip news sprint
Projects
Sprint 2024
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroIntensity @ericsnowcurrently