Skip to content

gh-95953: Add a css class to changed lines of difflib.HtmlDiff make_table #139226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 22, 2025
Merged

gh-95953: Add a css class to changed lines of difflib.HtmlDiff make_table #139226

merged 5 commits into from
Sep 22, 2025
+150 −144

Conversation

KatieLG
Copy link
Contributor

@KatieLG KatieLG commented Sep 22, 2025 •
edited
Loading

Adds a css_class diff_changed to the table cells for changed content in the HTML output of the make_table method in difflib.HtmlDiff

@python-cla-bot
Copy link

python-cla-bot bot commented Sep 22, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app bot mentioned this pull request Sep 22, 2025
Closed
@hugovk hugovk added the sprint label Sep 22, 2025
hugovk
hugovk reviewed Sep 22, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

@AA-Turner
Copy link
Member

Android failures look unrelated

AA-Turner
AA-Turner approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add yourself to Misc/ACKS!

A

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Sprint 2024 Sep 22, 2025
hugovk
hugovk approved these changes Sep 22, 2025
View reviewed changes
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution at the PyCon UK sprint!

@hugovk hugovk enabled auto-merge (squash) September 22, 2025 13:01
@hugovk hugovk merged commit e642a24 into python:main Sep 22, 2025
45 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sprint 2024 Sep 22, 2025
@Wulian233
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugovk hugovk hugovk approved these changes

@AA-Turner AA-Turner AA-Turner approved these changes

Assignees
No one assigned
Labels
sprint
Projects
Sprint 2024
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KatieLG @AA-Turner @Wulian233 @hugovk