Skip to content

gh-74857, PEP 538: Coerce POSIX locale to UTF-8 based locale #139238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2025
Merged

gh-74857, PEP 538: Coerce POSIX locale to UTF-8 based locale #139238

merged 2 commits into from
Sep 23, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 22, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 22, 2025
Closed
@vstinner
Copy link
Member Author

cc @ncoghlan

ncoghlan
ncoghlan reviewed Sep 22, 2025
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but there's a now-outdated Linux-specific setup clause in the test code that should be removed (we used to only test POSIX on Linux systems, but with it being added to the cross-platform set, we don't need to test it a second time).

@vstinner
Copy link
Member Author

@ncoghlan: Please review the updated PR.

ncoghlan
ncoghlan approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@ncoghlan ncoghlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vstinner vstinner merged commit e8382e5 into python:main Sep 23, 2025
49 checks passed
@vstinner vstinner deleted the posix_locale branch September 23, 2025 17:21
@vstinner
Copy link
Member Author

Merged, thanks for the review @ncoghlan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @ncoghlan