Skip to content

[3.13] Revert "gh-136006: fix Py_NAN expansion on Solaris systems (GH-136575) (#138734)" #139239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

[3.13] Revert "gh-136006: fix Py_NAN expansion on Solaris systems (GH-136575) (#138734)" #139239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions Include/pymath.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,24 +54,9 @@

/* Py_NAN: Value that evaluates to a quiet Not-a-Number (NaN). The sign is
* undefined and normally not relevant, but e.g. fixed for float("nan").
*
* Note: On Solaris, NAN is a function address, hence arithmetic is impossible.
* For that reason, we instead use the built-in call if available or fallback
* to a generic NaN computed from strtod() as a last resort.
*
* See https://github.com/python/cpython/issues/136006 for details.
*/
#if !defined(Py_NAN)
# if defined(__sun)
# if _Py__has_builtin(__builtin_nanf)
# define Py_NAN ((double)__builtin_nanf(""))
# else
# include <stdlib.h>
# define Py_NAN (strtod("NAN", NULL))
# endif
# else
# define Py_NAN ((double)NAN)
# endif
# define Py_NAN ((double)NAN)
#endif

#endif /* Py_PYMATH_H */
2 changes: 0 additions & 2 deletions Misc/NEWS.d/next/C API/2025-07-08-22-07-54.gh-issue-136006.XRU5w4.rst
View file
Open in desktop

This file was deleted.

Loading