gh-139246: zero-width word paste can be wrong in default repl #139254
+33
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618
changed the title
grayjk
suggested changes
Sep 23, 2025
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
grayjk
reviewed
Sep 24, 2025
Co-authored-by: grayjk <grayjk@gmail.com>
grayjk
reviewed
Sep 24, 2025
|
|
||
| @functools.cache | ||
| def str_width(c: str) -> int: | ||
| if ord(c) < 128: |
There was a problem hiding this comment.
unrelated to this issue but quite a few of the characters with ord < 128, do not have a display width of 1
for example, in my terminal, tab (ord 9) is 8 charaters wide
something to consider for a future PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.