-
-
Notifications
You must be signed in to change notification settings - Fork 33k
[3.9] gh-135374: Adjust test for setuptools' replacement of distutils (GH-138796) #139304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 3.9
Are you sure you want to change the base?
Conversation
…stutils (pythonGH-138796) ensurepip installs a bundled copy of distutils, which overrides the stdlib module. This affects several tests. This commit: - skips distutils in test___all__, as we're unlikely to break `__all__` in a security-fix-only branch (and if we do it's not much of a a big deal) - skips importability tests of distutils submodules if the setuptools hack is detected (cherry picked from commit 987af36) Co-authored-by: Petr Viktorin <encukou@gmail.com> Co-authored-by: Łukasz Langa <lukasz@langa.pl> Co-authored-by: Emma Smith <emma@emmatyping.dev>
!buildbot Installed |
🤖 New build scheduled with the buildbot fleet by @encukou for commit 7ef179f 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139304%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
!buildbot Installed |
🤖 New build scheduled with the buildbot fleet by @encukou for commit a613979 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139304%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
The failure on |
The failures on all Installed are all the pre-existing issue, in |
ensurepip installs a bundled copy of distutils, which overrides
the stdlib module. This affects several tests. This commit:
__all__
in a security-fix-only branch (and if we do it's notmuch of a a big deal)
setuptools hack is detected
(cherry picked from commit 987af36)
Co-authored-by: Petr Viktorin encukou@gmail.com
Co-authored-by: Łukasz Langa lukasz@langa.pl
Co-authored-by: Emma Smith emma@emmatyping.dev