-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-139353: Split unicodeobject.c into smaller files #139354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Line numbers:
|
To ease navigation, can we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For all new files, can we perhaps automatically apply some formatter? it would be a good practice to enforce a consistent style (unless you want people to be able to check the diff with part of the file).
I would however suggest that we still apply some post-formatting after the refactorization.
Ok, I renamed the file.
I would prefer to limit changes, only move code, to help Git to get the history. |
Create files: * Objects/unicode_codecs.c * Objects/unicode_codecs_utf.c * Objects/unicode_codecs_win.c * Objects/unicode_convert.c * Objects/unicode_format.c * Objects/unicode_fromformat.c * Objects/unicode_iter.c * Objects/unicode_methods.c * Objects/unicode_module.c * Objects/unicode_writer.c
ca8e49a
to
e507b4a
Compare
I closed/reopened the PR to trigger again CI jobs. |
I don't know why these 3 CIs are blocked :-( |
Create files: