Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 26, 2025

Create files:

  • Objects/unicode_codecs.c
  • Objects/unicode_codecs_utf.c
  • Objects/unicode_codecs_win.c
  • Objects/unicode_convert.c
  • Objects/unicode_format.c
  • Objects/unicode_fromformat.c
  • Objects/unicode_iter.c
  • Objects/unicode_methods.c
  • Objects/unicode_module.c
  • Objects/unicode_writer.c

@vstinner
Copy link
Member Author

vstinner commented Sep 26, 2025

Line numbers:

$ wc -l Objects/unicode*.c|sort -n
   209 Objects/unicode_iter.c
   287 Objects/unicodectype.c
   575 Objects/unicode_module.c
   657 Objects/unicode_fromformat.c
   688 Objects/unicode_writer.c
   809 Objects/unicode_codecs_win.c
   835 Objects/unicode_convert.c
   949 Objects/unicode_format.c
  2171 Objects/unicode_codecs_utf.c
  3179 Objects/unicode_methods.c
  3239 Objects/unicode_codecs.c
  3561 Objects/unicodeobject.c
 17159 total

@picnixz
Copy link
Member

picnixz commented Sep 26, 2025

To ease navigation, can we use codecs_utf instead? that way, the file will be close to codecs.c

Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all new files, can we perhaps automatically apply some formatter? it would be a good practice to enforce a consistent style (unless you want people to be able to check the diff with part of the file).

I would however suggest that we still apply some post-formatting after the refactorization.

@vstinner
Copy link
Member Author

To ease navigation, can we use codecs_utf instead? that way, the file will be close to codecs.c

Ok, I renamed the file.

For all new files, can we perhaps automatically apply some formatter? it would be a good practice to enforce a consistent style (unless you want people to be able to check the diff with part of the file).

I would prefer to limit changes, only move code, to help Git to get the history.

Create files:

* Objects/unicode_codecs.c
* Objects/unicode_codecs_utf.c
* Objects/unicode_codecs_win.c
* Objects/unicode_convert.c
* Objects/unicode_format.c
* Objects/unicode_fromformat.c
* Objects/unicode_iter.c
* Objects/unicode_methods.c
* Objects/unicode_module.c
* Objects/unicode_writer.c
@vstinner
Copy link
Member Author

I closed/reopened the PR to trigger again CI jobs.

@vstinner
Copy link
Member Author

vstinner commented Sep 30, 2025

All required checks pass Expected — Waiting for status to be reported
DO-NOT-MERGE Expected — Waiting for status to be reported
Unresolved review Expected — Waiting for status to be reported

I don't know why these 3 CIs are blocked :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants