gh-139391: properly handle signal.signal() in UnixConsole when called from a non-main thread
#139392
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
yihong0618
requested review from
pablogsal,
lysnikolaou and
ambv
as code owners
picnixz
reviewed
Sep 28, 2025
Signed-off-by: yihong0618 <zouzou0208@gmail.com> Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Sep 28, 2025
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
reviewed
Sep 28, 2025
picnixz
changed the title
signal.signal() in UnixConsole when called from a non-main thread
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
reviewed
Sep 29, 2025
Misc/NEWS.d/next/Library/2025-09-28-16-34-11.gh-issue-139391.nRFnmx.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
picnixz
approved these changes
Sep 29, 2025
|
I'll wait for @ambv to review this as well. |
Thank you very much! |
kumaraditya303
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after this patch it goes normal with ctrl+z and fg
python -m asyncioprocess is not properly handled on Unix-like platforms #139391