Skip to content

gh-139184: set O_CLOEXEC for master_fd when call os.forkpty #139408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-139184: set O_CLOEXEC for master_fd when call os.forkpty #139408

wants to merge 3 commits into from
+12 −0

Conversation

Zheaoli
Copy link
Contributor

@Zheaoli Zheaoli commented Sep 29, 2025 •
edited by bedevere-app bot
Loading

@Zheaoli
pythongh-139184: set O_CLOEXEC for master_fd when call os.forkpty
1d89309 
Signed-off-by: Manjusaka <me@manjusaka.me>
@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2025
Open
ashm-dev
ashm-dev suggested changes Sep 29, 2025
View reviewed changes
Zheaoli and others added 2 commits September 29, 2025 17:42
@Zheaoli @ashm-dev
Update Lib/test/test_pty.py
b0cf98a 
Co-authored-by: Shamil <ashm.tech@proton.me>
@Zheaoli
fix test
d9be40e 
Signed-off-by: Manjusaka <me@manjusaka.me>
ashm-dev
ashm-dev suggested changes Sep 29, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ashm-dev ashm-dev ashm-dev approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zheaoli @ashm-dev