Skip to content

gh-92266: Update pre-commit #139411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 1, 2025
Merged

gh-92266: Update pre-commit #139411

merged 4 commits into from
Oct 1, 2025
+10 −20

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 29, 2025 •
edited by bedevere-app bot
Loading

@hugovk hugovk added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes and removed awaiting core review labels Sep 29, 2025
@bedevere-app bedevere-app bot mentioned this pull request Sep 29, 2025
Closed
itamaro
itamaro approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@itamaro itamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the attached issue relevant to this PR?

@hugovk
Copy link
Member Author

hugovk commented Sep 30, 2025

Partially, that issue was the trigger for updating because Tools/c-analyzer/cpython/_parser.py was excluded from remove-tabs and #92266 (comment) notes it no longer has tabs.

But we can also skip-issue here if you like.

@itamaro
Copy link
Contributor

itamaro commented Oct 1, 2025

But we can also skip-issue here if you like.

Either would be fine

@hugovk hugovk merged commit 800d856 into python:main Oct 1, 2025
45 checks passed
@hugovk hugovk deleted the pre-commit-remove-tabs branch October 1, 2025 05:40
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2025
@hugovk @miss-islington
pythongh-92266: Update pre-commit (pythonGH-139411)
bb18c88 
(cherry picked from commit 800d856)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@miss-islington-app
Copy link

Sorry, @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 800d856bc78ec0431450361c346bc1e5996f6624 3.13

@bedevere-app
Copy link

bedevere-app bot commented Oct 1, 2025

GH-139466 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamaro itamaro itamaro approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees

@hugovk hugovk

Labels
needs backport to 3.13 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hugovk @itamaro @AlexWaygood @StanFromIreland