Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 2, 2025

Remove test_sites_no_connection_close() which is skipped since 2018 (commit 36d56ea).

Remove test_sites_no_connection_close() which is skipped since 2018
(commit 36d56ea).
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

Test skipped since 2018, since commit 36d56ea:

commit 36d56ea826caffbeac0fc0c6d90248b80516e33c
Author: INADA Naoki <methane@users.noreply.github.com>
Date:   Wed Apr 18 00:31:29 2018 +0900

    bpo-33295: Skip test using missing external site (GH-6504)
    
    `test_urllib2net.OtherNetworkTests.test_sites_no_connection_close`
    used `http://www.imdb.com/` but it is moved to https so the test is
    not valid anymore.  Skip test for the moment to allow CI to proceed.

See #77476.

@vstinner vstinner merged commit 8797e1a into python:main Oct 2, 2025
52 of 53 checks passed
@vstinner vstinner deleted the remove_http_test branch October 2, 2025 15:30
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

Merged, thanks for the review @orsenthil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants