gh-135329: Use longer timeout in pyrepl test_repl_eio() #139503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace hardcoded 5 seconds with support.SHORT_TIMEOUT.
Fix the following error on slow CI such as GitHub Action UBSan:
test test_pyrepl failed -- Traceback (most recent call last):
File "Lib/test/test_pyrepl/test_unix_console.py", line 362, in test_repl_eio
_, err = proc.communicate(timeout=5) # sleep for pty to settle
~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "Lib/subprocess.py", line 1219, in communicate
stdout, stderr = self._communicate(input, endtime, timeout)
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
File "Lib/subprocess.py", line 2126, in _communicate
self._check_timeout(endtime, orig_timeout, stdout, stderr)
~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "Lib/subprocess.py", line 1266, in _check_timeout
raise TimeoutExpired(
...<2 lines>...
stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '[...]' timed out after 5 seconds
vstinner
added
skip news
needs backport to 3.13
pablogsal
approved these changes
Oct 2, 2025
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 2, 2025
…GH-139503) Replace hardcoded 5 seconds with support.SHORT_TIMEOUT. Fix the following error on slow CI such as GitHub Action UBSan: test test_pyrepl failed -- Traceback (most recent call last): File "Lib/test/test_pyrepl/test_unix_console.py", line 362, in test_repl_eio _, err = proc.communicate(timeout=5) # sleep for pty to settle ~~~~~~~~~~~~~~~~^^^^^^^^^^^ File "Lib/subprocess.py", line 1219, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 2126, in _communicate self._check_timeout(endtime, orig_timeout, stdout, stderr) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 1266, in _check_timeout raise TimeoutExpired( ...<2 lines>... stderr=b''.join(stderr_seq) if stderr_seq else None) subprocess.TimeoutExpired: Command '[...]' timed out after 5 seconds (cherry picked from commit c985822) Co-authored-by: Victor Stinner <vstinner@python.org>
|
Sorry, @vstinner, I could not cleanly backport this to |
|
GH-139506 is a backport of this pull request to the 3.14 branch. |
|
GH-139507 is a backport of this pull request to the 3.13 branch. |
vstinner
added a commit
to vstinner/cpython
that referenced
this pull request
Oct 2, 2025
…#139503) Replace hardcoded 5 seconds with support.SHORT_TIMEOUT. Fix the following error on slow CI such as GitHub Action UBSan: test test_pyrepl failed -- Traceback (most recent call last): File "Lib/test/test_pyrepl/test_unix_console.py", line 362, in test_repl_eio _, err = proc.communicate(timeout=5) # sleep for pty to settle ~~~~~~~~~~~~~~~~^^^^^^^^^^^ File "Lib/subprocess.py", line 1219, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 2126, in _communicate self._check_timeout(endtime, orig_timeout, stdout, stderr) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 1266, in _check_timeout raise TimeoutExpired( ...<2 lines>... stderr=b''.join(stderr_seq) if stderr_seq else None) subprocess.TimeoutExpired: Command '[...]' timed out after 5 seconds (cherry picked from commit c985822)
|
Merged, thanks for the review @pablogsal. |
vstinner
added a commit
that referenced
this pull request
Oct 2, 2025
…) (#139507) gh-135329: Use longer timeout in pyrepl test_repl_eio() (#139503) Replace hardcoded 5 seconds with support.SHORT_TIMEOUT. Fix the following error on slow CI such as GitHub Action UBSan: test test_pyrepl failed -- Traceback (most recent call last): File "Lib/test/test_pyrepl/test_unix_console.py", line 362, in test_repl_eio _, err = proc.communicate(timeout=5) # sleep for pty to settle ~~~~~~~~~~~~~~~~^^^^^^^^^^^ File "Lib/subprocess.py", line 1219, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 2126, in _communicate self._check_timeout(endtime, orig_timeout, stdout, stderr) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 1266, in _check_timeout raise TimeoutExpired( ...<2 lines>... stderr=b''.join(stderr_seq) if stderr_seq else None) subprocess.TimeoutExpired: Command '[...]' timed out after 5 seconds (cherry picked from commit c985822)
vstinner
added a commit
that referenced
this pull request
Oct 7, 2025
…9503) (#139506) gh-135329: Use longer timeout in pyrepl test_repl_eio() (GH-139503) Replace hardcoded 5 seconds with support.SHORT_TIMEOUT. Fix the following error on slow CI such as GitHub Action UBSan: test test_pyrepl failed -- Traceback (most recent call last): File "Lib/test/test_pyrepl/test_unix_console.py", line 362, in test_repl_eio _, err = proc.communicate(timeout=5) # sleep for pty to settle ~~~~~~~~~~~~~~~~^^^^^^^^^^^ File "Lib/subprocess.py", line 1219, in communicate stdout, stderr = self._communicate(input, endtime, timeout) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 2126, in _communicate self._check_timeout(endtime, orig_timeout, stdout, stderr) ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "Lib/subprocess.py", line 1266, in _check_timeout raise TimeoutExpired( ...<2 lines>... stderr=b''.join(stderr_seq) if stderr_seq else None) subprocess.TimeoutExpired: Command '[...]' timed out after 5 seconds (cherry picked from commit c985822) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace hardcoded 5 seconds with support.SHORT_TIMEOUT.
Fix the following error on slow CI such as GitHub Action UBSan: