Skip to content

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 2, 2025

@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

cc @gpshead @picnixz @encukou

I cannot reproduce the failure on Linux, so I cannot check manually that it does fix #139504 on macOS.

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@picnixz
Copy link
Member

picnixz commented Oct 2, 2025

For now, let's do that. Unfortunately, I don't have a mac so I can't investigate more :( but since the tests are flaky, it's fine (at least, there isn't an issue with the implementation itself I'd say; and if there is, it'll likely be caught in another test as this function doesn't do anything fancy)

@vstinner vstinner merged commit ea4027e into python:main Oct 2, 2025
47 checks passed
@vstinner vstinner deleted the test_ssl_broken_pipe branch October 2, 2025 16:08
@vstinner
Copy link
Member Author

vstinner commented Oct 2, 2025

Ok, merged, thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir topic-SSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants