gh-139482: Improve performance of os.environ.clear() #139549
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation based on a suggestion from @gukoff.
When the
environ
is mutated during the execution ofos.environ.clear()
(via another thread, or via destructors of the keys removed), the result can be a non-empty environment after theclear()
. This is also the case for the current implementation, so this seems acceptable. The exact results can be different, but this seems unavoidable (in particular in the case of threads).A variation could be to add
super().clear()
at the end of the definition ofclear()
(this would not impact performance complexity)os.environ.clear()
has a quadratic time complexity #139482