gh-101100: Fix reference warnings in c-api/init.rst documenting PyGILState_STATE
#139572
Conversation
| will simply return ``NULL`` indicating that there was no prior thread state. | ||
| .. seealso: | ||
| .. seealso:: |
There was a problem hiding this comment.
hmm, this ought've been caught by sphinx-lint, cc @ezio-melotti @hugovk
There was a problem hiding this comment.
Open an issue at https://github.com/sphinx-contrib/sphinx-lint ?
| .. note:: | ||
| This function does not account for :term:`thread states <thread state>` created | ||
| by something other than :c:func:`PyGILState_Ensure` (such as :c:func:`PyThreadState_New`). |
There was a problem hiding this comment.
@ZeroIntensity: Is this change correct?
There was a problem hiding this comment.
I thought it was, above:
the PyGILState_GetThisThreadState change looks good.
There was a problem hiding this comment.
Oh, I didn't notice that @ZeroIntensity already reviewed the PR :-) So we're good :-)
hugovk
added
needs backport to 3.13
|
Thanks @StanFromIreland for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…ng `PyGILState_STATE` (pythonGH-139572) (cherry picked from commit d2deb8f) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
Sorry, @StanFromIreland and @hugovk, I could not cleanly backport this to |
|
GH-139832 is a backport of this pull request to the 3.14 branch. |
…cumenting `PyGILState_STATE` (pythonGH-139572) (cherry picked from commit d2deb8f) Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-139833 is a backport of this pull request to the 3.13 branch. |
PyGILState_STATE: If we don't want to document, I can add it to the ignore list.I also fixed two
.. seealso::blocks I noticed.📚 Documentation preview 📚: https://cpython-previews--139572.org.readthedocs.build/