-
-
Notifications
You must be signed in to change notification settings - Fork 33k
gh-139573: Update OpenSSL version used in iOS builds #139582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Assigning to @hugovk since this should be backported to 3.14 for the .0 release. |
the unpacked dependencies. | ||
""" | ||
# To create new builds of these dependencies, usually all that's necessary | ||
# is to push a tag to the cpython-apple-source-deps repository, and GitHub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like for this one it's more of pushing a simple Makefile update (and a tag) rather than just a tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will actually work on a tag; the Makefile does encode the "default" for the purposes of other CI checks, but a tag is sufficient to make the release.
Of course, a PR doesn't hurt, either.
Thanks! |
Thanks @freakboy3742 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
GH-139589 is a backport of this pull request to the 3.14 branch. |
Bumps the OpenSSL version used when building iOS XCframeworks.