-
-
Notifications
You must be signed in to change notification settings - Fork 33k
Replace ambiguous word "pound" by "hash" in difflib
docs
#139601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we make it pretty clear with "( |
@StanFromIreland, is there a way to do the indentation automatically in Vim/bash/VSCode? I've been doing it manually, which is why it looks odd. |
Possibly your editor has a default that is different than that of the file? Even in the docs the indentation can vary from file to file, I have made such a mistake before. |
difflib
Documentationdifflib
docs
Note that I totally agree with this change because I never knew that it was called a "pound" character. For me it was either the cardinality of something, or a hash(tag). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also never heard it used in Europe, I am familiar with the term via American media.
Thanks @George-Ogden for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
…139601) (cherry picked from commit dadbb2662a405a34763db0298025f6af06342849) Co-authored-by: George Ogden <38294960+George-Ogden@users.noreply.github.com>
GH-139616 is a backport of this pull request to the 3.14 branch. |
GH-139617 is a backport of this pull request to the 3.13 branch. |
This clears up what is meant by
IS_LINE_JUNK
and explains refers to#
as "the pound or hash symbol", rather than just "the pound symbol", which could mean £.📚 Documentation preview 📚: https://cpython-previews--139601.org.readthedocs.build/