Skip to content

Conversation

George-Ogden
Copy link
Contributor

@George-Ogden George-Ogden commented Oct 5, 2025

This clears up what is meant by IS_LINE_JUNK and explains refers to # as "the pound or hash symbol", rather than just "the pound symbol", which could mean £.


📚 Documentation preview 📚: https://cpython-previews--139601.org.readthedocs.build/

@StanFromIreland
Copy link
Member

StanFromIreland commented Oct 5, 2025

explains refers to # as "the pound or hash symbol", rather than just "the pound symbol", which could mean £.

I think we make it pretty clear with "('#')". As for your suggestion, adding "of the pound, or hash symbol" just makes it less clear IMO, as now it seems like we explicitly allow '£' OR '#'.

@George-Ogden
Copy link
Contributor Author

@StanFromIreland, is there a way to do the indentation automatically in Vim/bash/VSCode? I've been doing it manually, which is why it looks odd.

@StanFromIreland
Copy link
Member

Possibly your editor has a default that is different than that of the file? Even in the docs the indentation can vary from file to file, I have made such a mistake before.

@picnixz picnixz changed the title doc: Update Ambiguous difflib Documentation Replace ambiguous word "pound" by "hash" in difflib docs Oct 5, 2025
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 5, 2025
@picnixz picnixz enabled auto-merge (squash) October 5, 2025 17:06
@picnixz
Copy link
Member

picnixz commented Oct 5, 2025

Note that I totally agree with this change because I never knew that it was called a "pound" character. For me it was either the cardinality of something, or a hash(tag).

Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also never heard it used in Europe, I am familiar with the term via American media.

@picnixz picnixz merged commit dadbb26 into python:main Oct 5, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Oct 5, 2025
@miss-islington-app
Copy link

Thanks @George-Ogden for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2025
…139601)

(cherry picked from commit dadbb2662a405a34763db0298025f6af06342849)

Co-authored-by: George Ogden <38294960+George-Ogden@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2025
…139601)

(cherry picked from commit dadbb26)

Co-authored-by: George Ogden <38294960+George-Ogden@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 5, 2025

GH-139616 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 5, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 5, 2025

GH-139617 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 5, 2025
@George-Ogden George-Ogden deleted the fix-ambiguous-pound-sign branch October 5, 2025 17:11
picnixz pushed a commit that referenced this pull request Oct 5, 2025
…-139601) (#139617)

Replace ambiguous word "pound" by "hash" in `difflib` docs (GH-139601)
(cherry picked from commit dadbb26)

Co-authored-by: George Ogden <38294960+George-Ogden@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants