[3.14] gh-139400: Make sure that parent parsers outlive their subparsers in pyexpat (GH-139403)
#139606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs in `pyexpat` (pythonGH-139403) * Modules/pyexpat.c: Disallow collection of in-use parent parsers. Within libexpat, a parser created via `XML_ExternalEntityParserCreate` is relying on its parent parser throughout its entire lifetime. Prior to this fix, is was possible for the parent parser to be garbage-collected too early. (cherry picked from commit 6edb2dd) Co-authored-by: Sebastian Pipping <sebastian@pipping.org>
picnixz
approved these changes
Oct 5, 2025
|
GH-139663 is a backport of this pull request to the 3.14 branch. |
picnixz
pushed a commit
that referenced
this pull request
Oct 6, 2025
|
GH-139663 is a backport of this pull request to the 3.14 branch. |
hugovk
pushed a commit
that referenced
this pull request
Oct 6, 2025
danigm
pushed a commit
to openSUSE-Python/cpython
that referenced
this pull request
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within libexpat, a parser created via
XML_ExternalEntityParserCreateis relying on its parent parser throughout its entire lifetime.
Prior to this fix, is was possible for the parent parser to be
garbage-collected too early.
(cherry picked from commit 6edb2dd)
Co-authored-by: Sebastian Pipping sebastian@pipping.org
pyexpatrelated to.ExternalEntityParserCreate#139400