Skip to content

Conversation

yihong0618
Copy link
Contributor

@yihong0618 yihong0618 commented Oct 6, 2025

as diff

add follow the rule in comments typo in error can fix

#139405 (comment)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@yihong0618 yihong0618 marked this pull request as ready for review October 6, 2025 10:26
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 6, 2025
@picnixz picnixz enabled auto-merge (squash) October 6, 2025 10:48
@picnixz picnixz merged commit 36a6c2c into python:main Oct 6, 2025
55 checks passed
@miss-islington-app
Copy link

Thanks @yihong0618 for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
…9647)

(cherry picked from commit 36a6c2cdfaddc4a82d14f2c84b04e05089802876)

Co-authored-by: yihong <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
…9647)

(cherry picked from commit 36a6c2c)

Co-authored-by: yihong <zouzou0208@gmail.com>
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139649 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139650 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2025
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants