gh-137508: Unify error messages for index() and remove() #139696
+39
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unify error messages for the index() and remove() methods of classes list, tuple, range, memoryview, str, bytes, bytearray, array.array, and collections.deque, and the operator.indexOf() function. Improve error message for xml.etree.ElementTree.Element.remove().
rhettinger
reviewed
Oct 7, 2025
| return NULL; | ||
| } | ||
| PyErr_SetString(PyExc_ValueError, "list.remove(x): x not in list"); | ||
| PyErr_SetString(PyExc_ValueError, "value not in list"); |
There was a problem hiding this comment.
To me this just makes the messages slightly less informative. Personally, I don't see this as an improvement.
There was a problem hiding this comment.
I am not so strong proponent of this change, but I think that there is a benefit of having unified error messages whether it is possible. I'll left this PR until we have an overwhelming support of any variant.
rhettinger
reviewed
Oct 7, 2025
| } | ||
| } | ||
| PyErr_SetString(PyExc_ValueError, "deque.index(x): x not in deque"); | ||
| PyErr_SetString(PyExc_ValueError, "value not in deque"); |
There was a problem hiding this comment.
I prefer the message be left as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify error messages for the index() and remove() methods of classes list, tuple, range, memoryview, str, bytes, bytearray, array.array, and collections.deque, and the operator.indexOf() function.
Improve error message for xml.etree.ElementTree.Element.remove().
<sequence>.<method>()failures #137508