Skip to content

gh-138342: Move _PyObject_VisitType() to the internal C API #139734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

gh-138342: Move _PyObject_VisitType() to the internal C API #139734

merged 2 commits into from
Oct 8, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Oct 7, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 7, 2025
Closed
@vstinner vstinner mentioned this pull request Oct 7, 2025
Merged
@vstinner
Copy link
Member Author

vstinner commented Oct 7, 2025

cc @ZeroIntensity

@ZeroIntensity
Copy link
Member

I agree that we should move this to pycore_object.h.

@vstinner vstinner marked this pull request as ready for review October 7, 2025 23:46
@vstinner vstinner merged commit c4e7d24 into python:main Oct 8, 2025
49 checks passed
@vstinner vstinner deleted the object_visit_type branch October 8, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka serhiy-storchaka is a code owner

@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @ZeroIntensity