Skip to content

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 8, 2025

Sorry, I was late for #139591 review :)

I propose to remove ignore rules, because they are not actual for the code in this folder.

"YTT", # flake8-2020
]
ignore = [
"E501", # Line too long
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this one makes likely sense given we're auto-formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to keep it, so we can reduce the diff :)

@sobolevn sobolevn merged commit 678e0b8 into python:main Oct 8, 2025
47 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
)

(cherry picked from commit 678e0b818c0d6063907f55263bbc0e194b492c8e)

Co-authored-by: sobolevn <mail@sobolevn.me>
@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 678e0b818c0d6063907f55263bbc0e194b492c8e 3.13

@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2025

GH-139811 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 678e0b8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/12380) and take a look at the build logs.
  4. Check if the failure is related to this commit (678e0b8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/12380

Failed tests:

  • test.test_os.test_os

Failed subtests:

  • test_timerfd_select - test.test_os.test_os.TimerfdTests.test_timerfd_select

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_os/test_os.py", line 3883, in test_timerfd_select
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants