Skip to content

gh-139805: Bump test_repl_eio timeout for slow builtbots #139807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2025
Merged

gh-139805: Bump test_repl_eio timeout for slow builtbots #139807

merged 1 commit into from
Oct 8, 2025

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Oct 8, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Oct 8, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 8, 2025
Closed
@StanFromIreland
Copy link
Member Author

Requested Victor as you previously bumped it.

@vstinner
Copy link
Member

vstinner commented Oct 8, 2025

I don't have access to the worker. According to #139805 (comment) it uses currently a timeout of 60 seconds which is already long. Are you sure that a longer timeout will solve the issue?

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Oct 8, 2025 •
edited
Loading

Are you sure that a longer timeout will solve the issue?

With the longer timeout, I was unable to reproduce even under very high load.

Let's run the buildbots.

@StanFromIreland
Copy link
Member Author

!buildbot Raspbian

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 850a1b3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139807%2Fmerge

The command will test the builders whose names match following regular expression: Raspbian

The builders matched are:

  • ARM Raspbian PR
  • ARM64 Raspbian PR
  • ARM Raspbian Linux Asan PR
  • ARM64 Raspbian Debug PR

vstinner
vstinner approved these changes Oct 8, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the longer timeout, I was unable to reproduce even under very high load.

Oh ok. I trust you on the fix in this case ;-)

@vstinner
Copy link
Member

vstinner commented Oct 8, 2025

buildbot/ARM64 Raspbian Debug PR — Build done.
buildbot/ARM64 Raspbian PR — Build done.

Tests passed on the two buildbots.

@vstinner vstinner merged commit e7e3d1d into python:main Oct 8, 2025
59 checks passed
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 8, 2025
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@StanFromIreland @miss-islington
pythongh-139805: Bump test_repl_eio timeout for slow builtbots (pyt…
a49a489 
…honGH-139807)

(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@StanFromIreland @miss-islington
pythongh-139805: Bump test_repl_eio timeout for slow builtbots (pyt…
c9e0e58 
…honGH-139807)

(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2025

GH-139812 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2025

GH-139813 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 8, 2025
@vstinner
Copy link
Member

vstinner commented Oct 8, 2025

Merged, thank you for the fix.

vstinner pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @StanFromIreland
[3.13] gh-139805: Bump test_repl_eio timeout for slow builtbots (GH…
8234841 
…-139807) (#139813)

gh-139805: Bump `test_repl_eio` timeout for slow builtbots (GH-139807)
(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
vstinner pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @StanFromIreland
[3.14] gh-139805: Bump test_repl_eio timeout for slow builtbots (GH…
56072f9 
…-139807) (#139812)

gh-139805: Bump `test_repl_eio` timeout for slow builtbots (GH-139807)
(cherry picked from commit e7e3d1d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland StanFromIreland deleted the long-timeout branch October 9, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

+1 more reviewer

@cmaloney cmaloney cmaloney approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @vstinner @bedevere-bot @cmaloney