Skip to content

gh-139905: Provide suggestion in error message if Generic.__init_subclass__ was not called #139943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2025
Merged

gh-139905: Provide suggestion in error message if Generic.__init_subclass__ was not called #139943

merged 5 commits into from
Oct 11, 2025
+45 −2

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Oct 11, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 11, 2025
Closed
picnixz
picnixz requested changes Oct 11, 2025
View reviewed changes
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@StanFromIreland
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

Thanks for making the requested changes!

@picnixz: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from picnixz October 11, 2025 13:05
picnixz
picnixz reviewed Oct 11, 2025
View reviewed changes
picnixz
picnixz approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo my comment on the msg.

AlexWaygood
AlexWaygood reviewed Oct 11, 2025
View reviewed changes
AlexWaygood
AlexWaygood approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

JelleZijlstra
JelleZijlstra reviewed Oct 11, 2025
View reviewed changes
@JelleZijlstra
Copy link
Member

Should we backport this? It seems pretty safe but maybe a better error message should be seen as a feature, not a bugfix.

@AlexWaygood
Copy link
Member

Should we backport this? It seems pretty safe but maybe a better error message should be seen as a feature, not a bugfix.

I was also wondering this. The existing error message is so confusing that I lean towards backporting here tbh, especially since — as you say — it does seem pretty safe

@AlexWaygood AlexWaygood enabled auto-merge (squash) October 11, 2025 15:06
@JelleZijlstra JelleZijlstra added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 11, 2025
@AlexWaygood AlexWaygood merged commit 5776d0d into python:main Oct 11, 2025
49 checks passed
@miss-islington-app
Copy link

Thanks @StanFromIreland for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2025
@StanFromIreland @miss-islington
pythongh-139905: Provide suggestion in error message if `Generic.__in…
04872e7 
…it_subclass__` was not called (pythonGH-139943)

(cherry picked from commit 5776d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 11, 2025
@StanFromIreland @miss-islington
pythongh-139905: Provide suggestion in error message if `Generic.__in…
8c75410 
…it_subclass__` was not called (pythonGH-139943)

(cherry picked from commit 5776d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

GH-139955 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 11, 2025
@bedevere-app
Copy link

bedevere-app bot commented Oct 11, 2025

GH-139956 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 11, 2025
@StanFromIreland StanFromIreland deleted the hinting branch October 11, 2025 15:17
AlexWaygood pushed a commit that referenced this pull request Oct 11, 2025
@miss-islington @StanFromIreland
[3.13] gh-139905: Provide suggestion in error message if `Generic.__i…
cbb415e 
…nit_subclass__` was not called (GH-139943) (#139956)

gh-139905: Provide suggestion in error message if `Generic.__init_subclass__` was not called (GH-139943)
(cherry picked from commit 5776d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
AlexWaygood pushed a commit that referenced this pull request Oct 11, 2025
@miss-islington @StanFromIreland
[3.14] gh-139905: Provide suggestion in error message if `Generic.__i…
46148d1 
…nit_subclass__` was not called (GH-139943) (#139955)

gh-139905: Provide suggestion in error message if `Generic.__init_subclass__` was not called (GH-139943)
(cherry picked from commit 5776d0d)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@StanFromIreland @JelleZijlstra @AlexWaygood @picnixz