Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions Lib/test/test_genericalias.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,20 @@ class C(list[int]):
self.assertEqual(C.__bases__, (list,))
self.assertEqual(C.__class__, type)

class Foo:
def __init_subclass__(cls) -> None:
pass

class Bar:
def __init_subclass__(cls) -> None:
super().__init_subclass__()

class FooSub[T](Foo): pass
class BarSub[T](Bar): pass
with self.assertRaisesRegex(RuntimeError, '__parameters__'):
_ = FooSub[int]
_ = BarSub[int]

def test_class_methods(self):
t = dict[int, None]
self.assertEqual(dict.fromkeys(range(2)), {0: None, 1: None}) # This works
Expand Down
3 changes: 3 additions & 0 deletions Lib/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1158,6 +1158,9 @@ def _generic_class_getitem(cls, args):
f"Parameters to {cls.__name__}[...] must all be unique")
else:
# Subscripting a regular Generic subclass.
if not hasattr(cls, "__parameters__"):
raise RuntimeError(f"{cls.__name__} has no __parameters__, "
f"you may forget to call super().__init_subclass__()")
for param in cls.__parameters__:
prepare = getattr(param, '__typing_prepare_subst__', None)
if prepare is not None:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Print better error message when subclassing `GenericAlias` without calling
``super().__init_subclass__``.
Loading