Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions Lib/test/test_typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -4674,6 +4674,34 @@ class D(Generic[T]): pass
with self.assertRaises(TypeError):
D[()]

def test_generic_init_subclass_not_called_error(self):
notes = ["Note: this exception may have been caused by "
r"'GenericTests.test_generic_init_subclass_not_called_error.<locals>.Base.__init_subclass__' "
"(or the '__init_subclass__' method on a superclass) not calling 'super().__init_subclass__()'"]

class Base:
def __init_subclass__(cls) -> None:
# Oops, I forgot super().__init_subclass__()!
pass

with self.subTest():
class Sub(Base, Generic[T]):
pass

with self.assertRaises(AttributeError) as cm:
Sub[int]

self.assertEqual(cm.exception.__notes__, notes)

with self.subTest():
class Sub[U](Base):
pass

with self.assertRaises(AttributeError) as cm:
Sub[int]

self.assertEqual(cm.exception.__notes__, notes)

def test_generic_subclass_checks(self):
for typ in [list[int], List[int],
tuple[int, str], Tuple[int, str],
Expand Down
16 changes: 14 additions & 2 deletions Lib/typing.py
Original file line number Diff line number Diff line change
Expand Up @@ -1142,14 +1142,26 @@ def _generic_class_getitem(cls, args):
f"Parameters to {cls.__name__}[...] must all be unique")
else:
# Subscripting a regular Generic subclass.
for param in cls.__parameters__:
try:
parameters = cls.__parameters__
except AttributeError as e:
init_subclass = getattr(cls, '__init_subclass__', None)
if init_subclass not in {None, Generic.__init_subclass__}:
e.add_note(
f"Note: this exception may have been caused by "
f"{init_subclass.__qualname__!r} (or the "
f"'__init_subclass__' method on a superclass) not "
f"calling 'super().__init_subclass__()'"
)
raise
for param in parameters:
prepare = getattr(param, '__typing_prepare_subst__', None)
if prepare is not None:
args = prepare(cls, args)
_check_generic_specialization(cls, args)

new_args = []
for param, new_arg in zip(cls.__parameters__, args):
for param, new_arg in zip(parameters, args):
if isinstance(param, TypeVarTuple):
new_args.extend(new_arg)
else:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Add suggestion to error message for :class:`typing.Generic` subclasses when
``cls.__parameters__`` is missing due to a parent class failing to call
:meth:`super().__init_subclass__() <object.__init_subclass__>` in its ``__init_subclass__``.
Loading