gh-139958: Add TOML MIME type #139959
Open
gh-139958: Add TOML MIME type #139959
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforcada
force-pushed
the
add-more-mimetypes
branch
from
b3f4446 to
f5c2435
Compare
| '.aiff' : 'audio/x-aiff', | ||
| '.ra' : 'audio/x-pn-realaudio', | ||
| '.wav' : 'audio/vnd.wave', | ||
| '.weba' : 'audio/webm', |
There was a problem hiding this comment.
Why this unrelated change?
There was a problem hiding this comment.
As the commit explains, they were not sorted. The font/ related mimetypes had this audio/ mimetype in between.
There was a problem hiding this comment.
In general please don't mix in changes, it is more difficult to review as a result.
Misc/NEWS.d/next/Library/2025-10-11-17-41-26.gh-issue-139958.AnCakj.rst
Outdated
Show resolved
Hide resolved
…nCakj.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
while doing some contributions for Plone (on Products.MimetypesRegistry distribution) I drifted away and eventually noticed that TOML files are not recognized by
mimetypesmodule.I followed this commit as in what to change.
Compared to the commit referenced above, I decided to skip updating
Doc/whatsnew/3.15.rstas it feels way too small of a change to mention it.Let me know if it should still be updated nonetheless.