Skip to content

gh-139988: fix a leak when failing to create a Union type #139990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2025
Merged

gh-139988: fix a leak when failing to create a Union type #139990

merged 1 commit into from
Oct 12, 2025

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Oct 12, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 12, 2025
Closed
@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
@picnixz picnixz merged commit 6710156 into python:main Oct 12, 2025
53 checks passed
@picnixz picnixz deleted the fix/leak/union-builder-139988 branch October 12, 2025 10:51
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
@picnixz @miss-islington
pythongh-139988: fix a leak when failing to create a Union type (pyth…
2e5ca5c 
…onGH-139990)

(cherry picked from commit 6710156)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Oct 12, 2025

GH-139993 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
picnixz added a commit that referenced this pull request Oct 12, 2025
@miss-islington @picnixz
[3.14] gh-139988: fix a leak when failing to create a Union type (GH-…
3b9694a 
…139990) (#139993)

gh-139988: fix a leak when failing to create a Union type (GH-139990)
(cherry picked from commit 6710156)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @kumaraditya303