Skip to content

Conversation

jlvandenhout
Copy link

@jlvandenhout jlvandenhout commented Jun 12, 2019

Currently when building an extension which lists a SWIG interface (.i) file as a source file, SWIG creates the files correctly in the build_ext command. Unfortunately this command is run after the build_py command, so the python files (.py) created in the build_ext command are never copied to the installation.

Swapping the build_ext and build_py commands in the sub_commands attribute of the build command fixes this issue.

https://bugs.python.org/issue37247

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@csabella
Copy link
Contributor

Since this is from an unknown repository and there was discussion on the bug tracker about the best way to implement this, I'm going to close this pull request. Once consensus is reached on the bug tracker, then a new pull request can be created. Thank you.

@csabella csabella closed this Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants