Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37351: Removes libpython38.a from standard Windows distribution #14276

Merged
merged 1 commit into from Jun 21, 2019

Conversation

@zooba
Copy link
Member

commented Jun 20, 2019

@zooba zooba requested a review from python/windows-team as a code owner Jun 20, 2019

@zooba zooba removed the DO-NOT-MERGE label Jun 21, 2019

@zooba zooba merged commit f569092 into python:master Jun 21, 2019

5 checks passed

Azure Pipelines PR #20190620.42 succeeded
Details
bedevere/issue-number Issue number 37351 found
Details
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Jun 21, 2019

@zooba: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington

This comment has been minimized.

Copy link

commented Jun 21, 2019

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Jun 21, 2019

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f5690925df897cf45818bf944b28d13f37b9f8ca 3.8

@zooba zooba deleted the zooba:bpo-37351 branch Jun 21, 2019

@bedevere-bot

This comment has been minimized.

Copy link

commented Jun 21, 2019

GH-14298 is a backport of this pull request to the 3.8 branch.

@bedevere-bot

This comment has been minimized.

Copy link

commented Jun 21, 2019

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Installed with X 3.x has failed when building commit f569092.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/103/builds/2686) and take a look at the build logs.
  4. Check if the failure is related to this commit (f569092) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/103/builds/2686

Click to see traceback logs
From https://github.com/python/cpython
 * branch                  master     -> FETCH_HEAD
Reset branch 'master'

Objects/unicodeobject.c: In function ‘_PyUnicode_CheckConsistency’:
Objects/unicodeobject.c:459:15: warning: variable ‘data’ set but not used [-Wunused-but-set-variable]
         void *data;
               ^~~~
Python/peephole.c: In function ‘PyCode_Optimize’:
Python/peephole.c:258:19: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘Py_ssize_t’ {aka ‘int’} [-Wsign-compare]
     for (j = 0; j < tabsiz; j += 2) {
                   ^
Python/pystrhex.c: In function ‘_Py_strhex_impl’:
Python/pystrhex.c:60:27: warning: comparison of integer expressions of different signedness: ‘unsigned int’ and ‘Py_ssize_t’ {aka ‘const int’} [-Wsign-compare]
     if (abs_bytes_per_sep >= arglen) {
                           ^~

/buildbot/tmp/tmpdir/tmpggoihase/pip-19.0.3-py2.py3-none-any.whl/pip/_vendor/pyparsing.py:3068: SyntaxWarning: invalid escape sequence \w
/buildbot/tmp/tmpdir/tmpggoihase/pip-19.0.3-py2.py3-none-any.whl/pip/_vendor/pyparsing.py:3068: SyntaxWarning: invalid escape sequence \w

zooba added a commit that referenced this pull request Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.