Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up[3.8] bpo-35224: Reverse evaluation order of key: value in dict comprehensions (GH-14139) #14314
Conversation
the-knights-who-say-ni
added
the
CLA signed
label
Jun 22, 2019
bedevere-bot
added
the
awaiting review
label
Jun 22, 2019
gvanrossum
approved these changes
Jun 22, 2019
bedevere-bot
added
awaiting merge
and removed
awaiting review
labels
Jun 22, 2019
This comment has been minimized.
This comment has been minimized.
|
Once this lands, #14313 needs to be backported. |
This comment has been minimized.
This comment has been minimized.
|
@joernheissler: Status check is done, and it's a success |
miss-islington
merged commit 874ff65
into
python:3.8
Jun 22, 2019
6 checks passed
bedevere/maintenance-branch-pr
Valid maintenance branch PR title.
bedevere/news
News entry found in Misc/NEWS.d
bedevere-bot
removed
the
awaiting merge
label
Jun 22, 2019
miss-islington
deleted the
miss-islington:backport-c8a3541-3.8
branch
Jun 22, 2019
This comment has been minimized.
This comment has been minimized.
|
@joernheissler: Status check is done, and it's a success |
1 similar comment
This comment has been minimized.
This comment has been minimized.
|
@joernheissler: Status check is done, and it's a success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
miss-islington commentedJun 22, 2019
•
edited by bedevere-bot
… as proposed in PEP 572; key is now evaluated before value.
https://bugs.python.org/issue35224
(cherry picked from commit c8a3541)
Co-authored-by: Jörn Heissler joernheissler@users.noreply.github.com
https://bugs.python.org/issue35224