Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upbpo-37553: SendfileUsingSendTest tests timeout too short for Windows … #14716
Conversation
…ARM32
This comment has been minimized.
This comment has been minimized.
|
/cc @giampaolo |
This comment has been minimized.
This comment has been minimized.
|
I'll merge this, but if it doesn't help the buildbot then let's revert it @paulmon |
This comment has been minimized.
This comment has been minimized.
|
If it does help, then we can backport to 3.8. But the buildbot is running against 3.x only now. |
This comment has been minimized.
This comment has been minimized.
|
The first pass with this fix passed the test_socket tests. We need more test passes to see if it's still randomly failing. I'll keep an eye on it. |
This comment has been minimized.
This comment has been minimized.
|
It looks like increasing this timeout works. The socket tests have all passed on the Windows ARM32 buildbot workers since making this change. |
LorenzMende
added a commit
to LorenzMende/cpython
that referenced
this pull request
Aug 11, 2019
…ARM32 (pythonGH-14716)
lisroach
added a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…ARM32 (pythonGH-14716)
DinoV
added a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…ARM32 (pythonGH-14716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
paulmon commentedJul 11, 2019
•
edited by bedevere-bot
The timeout error reproduces very infrequently when test_socket tests are run manually on a Raspberry Pi 3 running Windows IoT Core. I was able to determine that this timeout is the one causing the failure by making it smaller (0.01 seconds) which caused the tests in question to fail every time.
I would like to increase the timeout only if the test machine is running Windows ARM32 (aka ARM).
@zooba
https://bugs.python.org/issue37553