Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-37553: SendfileUsingSendTest tests timeout too short for Windows … #14716

Merged
merged 1 commit into from Jul 14, 2019

Conversation

@paulmon
Copy link
Contributor

paulmon commented Jul 11, 2019

The timeout error reproduces very infrequently when test_socket tests are run manually on a Raspberry Pi 3 running Windows IoT Core. I was able to determine that this timeout is the one causing the failure by making it smaller (0.01 seconds) which caused the tests in question to fail every time.

I would like to increase the timeout only if the test machine is running Windows ARM32 (aka ARM).

@zooba

https://bugs.python.org/issue37553

@mangrisano

This comment has been minimized.

Copy link
Contributor

mangrisano commented Jul 12, 2019

@zooba

This comment has been minimized.

Copy link
Member

zooba commented Jul 14, 2019

I'll merge this, but if it doesn't help the buildbot then let's revert it @paulmon

@zooba zooba merged commit 52c8c09 into python:master Jul 14, 2019
5 checks passed
5 checks passed
Azure Pipelines PR #20190711.43 succeeded
Details
bedevere/issue-number Issue number 37553 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zooba

This comment has been minimized.

Copy link
Member

zooba commented Jul 14, 2019

If it does help, then we can backport to 3.8. But the buildbot is running against 3.x only now.

@paulmon

This comment has been minimized.

Copy link
Contributor Author

paulmon commented Jul 15, 2019

The first pass with this fix passed the test_socket tests. We need more test passes to see if it's still randomly failing. I'll keep an eye on it.

@paulmon paulmon deleted the paulmon:buildbot_socket_timeout branch Jul 17, 2019
@paulmon

This comment has been minimized.

Copy link
Contributor Author

paulmon commented Jul 19, 2019

It looks like increasing this timeout works. The socket tests have all passed on the Windows ARM32 buildbot workers since making this change.

LorenzMende added a commit to LorenzMende/cpython that referenced this pull request Aug 11, 2019
lisroach added a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
DinoV added a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.