Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.8] bpo-36974: separate vectorcall functions for each calling convention (GH-13781) #14782

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@jdemeyer
Copy link
Contributor

commented Jul 15, 2019

Backport #13781 (part of the PEP 590 implementation) to 3.8 to fix a performance regression, see bpo-37562.

CC @vstinner @pablogsal @ambv

https://bugs.python.org/issue36974

@pablogsal

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

I will run pyperformance today to confirm if this fixes the regression. Thanks for the PR @jdemeyer!

@rhettinger rhettinger self-assigned this Jul 23, 2019

@rhettinger

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

I can confirm this fixes the performance regression. Please apply this backport.

@ambv ambv merged commit bf8e82f into python:3.8 Jul 23, 2019

6 checks passed

Azure Pipelines PR #20190715.8 succeeded
Details
bedevere/issue-number Issue number 36974 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot

This comment has been minimized.

Copy link

commented Jul 23, 2019

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

One day I'll remember to replace # with GH-. It will be a glorious day.

@rhettinger

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

Thanks for fixing this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.