Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in math.prod example #15614

Merged
merged 1 commit into from Sep 9, 2019
Merged

Typo in math.prod example #15614

merged 1 commit into from Sep 9, 2019

Conversation

ashwinvis
Copy link
Contributor

Trivial change in whatsnew document for 3.8.

Change in whatsnew document for 3.8.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching this. cc: @rhettinger

Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGM

@eamanu
Copy link
Contributor

eamanu commented Sep 1, 2019

Hi @ashwinvis Thanks for the contribution. Please don't forget the CLA :-)

@ashwinvis
Copy link
Contributor Author

Done

Copy link
Contributor

@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ashwinvis.

The changes look good to me. Since this is a typo correction, we can skip the bpo issue and news entry (particularly since it's correcting "what's new"). Also, this should be backported 3.8.

@aeros aeros added the needs backport to 3.8 only security fixes label Sep 2, 2019
@pablogsal pablogsal merged commit 1a8de82 into python:master Sep 9, 2019
@miss-islington
Copy link
Contributor

Thanks @ashwinvis for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2019
(cherry picked from commit 1a8de82)

Co-authored-by: Ashwin Vishnu <9155111+ashwinvis@users.noreply.github.com>
@bedevere-bot
Copy link

GH-15772 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 9, 2019
@pablogsal
Copy link
Member

Thanks @ashwinvis for your contribution!

miss-islington added a commit that referenced this pull request Sep 9, 2019
(cherry picked from commit 1a8de82)

Co-authored-by: Ashwin Vishnu <9155111+ashwinvis@users.noreply.github.com>
@ashwinvis ashwinvis deleted the patch-1 branch May 14, 2020 00:39
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants