bpo-37630: Use SHA3 and SHAKE XOF from OpenSSL #16049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
8 times, most recently
from
844ebfb to
8303e57
Compare
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
2 times, most recently
from
d4ba8b4 to
2668569
Compare
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
2 times, most recently
from
b35c29e to
0c5e988
Compare
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
2 times, most recently
from
5d212e6 to
8804740
Compare
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
from
8804740 to
f31da42
Compare
gpshead
reviewed
May 15, 2020
Misc/NEWS.d/next/Library/2020-05-15-19-53-18.bpo-37630.O5kgAw.rst
Outdated
Show resolved
Hide resolved
|
@gpshead Thanks for the review, I have addressed all your comments. |
OpenSSL 1.1.1 comes with SHA3 and SHAKE builtin. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
from
9aec2b2 to
386a3b5
Compare
|
@gpshead I found another issue. |
Also fixes a NULL ptr deref and segmentation fault. Signed-off-by: Christian Heimes <christian@python.org>
tiran
force-pushed
the
bpo-37630-hashlib-sha3
branch
from
386a3b5 to
e90a5c4
Compare
gpshead
approved these changes
May 16, 2020
arturoescaip
pushed a commit
to arturoescaip/cpython
that referenced
this pull request
May 24, 2020
OpenSSL 1.1.1 comes with SHA3 and SHAKE builtin. Signed-off-by: Christian Heimes <christian@python.org> Automerge-Triggered-By: @tiran
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 1.1.1 comes with SHA3 and SHAKE builtin.
Signed-off-by: Christian Heimes christian@python.org
https://bugs.python.org/issue37630
Automerge-Triggered-By: @tiran