[3.7] bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies (GH-13921) #16089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…okies (pythonGH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com>
asvetlov
approved these changes
Sep 13, 2019
|
@tirkarthi: Status check is done, and it's a failure ❌ . |
|
Ah okay there is no |
|
@tirkarthi: Status check is done, and it's a failure ❌ . |
|
Superseded by #16092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle time comparison for cookies with
expiresattribute whenCookieJar.make_cookiesis called.Co-authored-by: Demian Brecht demianbrecht@gmail.com
https://bugs.python.org/issue12144
Automerge-Triggered-By: @asvetlov
(cherry picked from commit bb41147)
Co-authored-by: Xtreak tir.karthi@gmail.com
https://bugs.python.org/issue12144