Skip to content

bpo-38236: Dump path config at first import error #16300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2019
Merged

bpo-38236: Dump path config at first import error #16300

merged 1 commit into from
Sep 23, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Sep 20, 2019 •
edited by bedevere-bot
Loading

Python now dumps path configuration if it fails to import the Python
codecs of the filesystem and stdio encodings.

https://bugs.python.org/issue38236

@vstinner
Copy link
Member Author

See https://bugs.python.org/issue38236#msg352873 for an output example.

matrixise
matrixise approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this feature, sometimes, I have this error. Need to fix the conflict? Thank you

@vstinner
bpo-38236: Dump path config at first import error
e249541 
Python now dumps path configuration if it fails to import the Python
codecs of the filesystem and stdio encodings.
@vstinner vstinner requested a review from a team as a code owner September 23, 2019 11:38
@vstinner vstinner merged commit fcdb027 into python:master Sep 23, 2019
@vstinner vstinner deleted the dump_pathconfig branch September 23, 2019 12:45
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @vstinner, I could not cleanly backport this to 3.8 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fcdb027234566c4d506d6d753c7d5638490fb088 3.8

@bedevere-bot
Copy link

GH-16332 is a backport of this pull request to the 3.8 branch.

vstinner added a commit that referenced this pull request Sep 23, 2019
@vstinner
bpo-38236: Dump path config at first import error (GH-16300) (GH-16332)
c5c6425 
Python now dumps path configuration if it fails to import the Python
codecs of the filesystem and stdio encodings.

(cherry picked from commit fcdb027)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

@methane methane methane approved these changes

Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vstinner @miss-islington @bedevere-bot @matrixise @methane @the-knights-who-say-ni