bpo-38366: dataclasses: generate the _hash_action table more cleanly #16547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: @iomintz This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
ioistired
changed the title
currently it's a table, which is more efficient than an if-else chain, but less efficient. We can have the best of both worlds by converting https://bugs.python.org/issue32929#msg312829 into a loop that generates the table that we currently have.
ioistired
force-pushed
the
dataclasses-gen-hash-action
branch
from
9c3bff4 to
4ce0344
Compare
|
I'm going to reject this PR. See my rationale in the BPO issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently it's a table, which is more efficient than an if-else chain,
but less efficient. We can have the best of both worlds by converting https://bugs.python.org/issue32929#msg312829
into a loop that generates the table that we currently have. This should make the table easier to maintain and understand.
https://bugs.python.org/issue38366