Skip to content

[3.7] bpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503) #16597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2019
Merged

[3.7] bpo-38332: Catch KeyError from unknown cte in encoded-word. (GH-16503) #16597

merged 1 commit into from
Oct 12, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 5, 2019 •
edited by bedevere-bot
Loading

KeyError should cause a failure in parsing the encoded word and should be caught and raised as a _InvalidEWError instead.
(cherry picked from commit 65dcc8a)

Co-authored-by: Andrei Troie andreitroie90@gmail.com

https://bugs.python.org/issue38332

@aft90 @miss-islington
bpo-38332: Catch KeyError from unknown cte in encoded-word. (pythonGH…
61cc90d 
…-16503)

KeyError should cause a failure in parsing the encoded word and should be caught and raised as a _InvalidEWError instead.
(cherry picked from commit 65dcc8a)

Co-authored-by: Andrei Troie <andreitroie90@gmail.com>
@miss-islington miss-islington requested a review from a team as a code owner October 5, 2019 16:19
@bedevere-bot bedevere-bot mentioned this pull request Oct 5, 2019
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Oct 5, 2019
@miss-islington
Copy link
Contributor Author

@aft90 and @maxking: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@aft90 and @maxking: Status check is done, and it's a success ✅ .

@ned-deily
Copy link
Member

@maxking, any reason to not merge this backport?

@miss-islington miss-islington merged commit febe359 into python:3.7 Oct 12, 2019
@miss-islington miss-islington deleted the backport-65dcc8a-3.7 branch October 12, 2019 17:02
@maxking
Copy link
Contributor

maxking commented Oct 12, 2019

@ned-deily I was waiting for rc-period, but I guess I don't have to :) Merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@maxking maxking maxking approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miss-islington @ned-deily @maxking @the-knights-who-say-ni @bedevere-bot @aft90