Skip to content

bpo-39050: The Help button in IDLE's config menu does not work #17611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 23, 2020
Merged

bpo-39050: The Help button in IDLE's config menu does not work #17611

merged 9 commits into from
Jan 23, 2020

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Dec 14, 2019 •
edited by bedevere-bot
Loading

@ZackerySpytz
Copy link
Contributor Author

The text param of view_text() was renamed to contents in 3221a63.

I don't think this fix needs a news entry.

@terryjreedy
Copy link
Member

This gets a news entry, so people know that they can use the button again. I will add one if still needed when merging.

csabella
csabella reviewed Jan 19, 2020
View reviewed changes
@csabella
Copy link
Contributor

Thanks, @ZackerySpytz. Please also add the News Entry that Terry requested.

@terryjreedy
Copy link
Member

I added a test that would have failed and caught the regression. This was part of the 6% still not covered. Zack, thanks for reporting and finding the reason.

@terryjreedy terryjreedy added needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Jan 23, 2020
@terryjreedy terryjreedy merged commit 2e43b64 into python:master Jan 23, 2020
@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @ZackerySpytz and @terryjreedy, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 2e43b64c94e49f7133b9c26e84c9519935c49063 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@ZackerySpytz @miss-islington
bpo-39050: The Help button in IDLE's config menu works again (pythonG…
b0e03e9 
…H-17611)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-18136 is a backport of this pull request to the 3.7 branch.

@miss-islington
Copy link
Contributor

Thanks @ZackerySpytz for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 23, 2020
@ZackerySpytz @miss-islington
bpo-39050: The Help button in IDLE's config menu works again (pythonG…
fc4f20a 
…H-17611)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link

GH-18137 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington @ZackerySpytz
bpo-39050: The Help button in IDLE's config menu works again (GH-17611)
ba83d1e 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jan 23, 2020
@miss-islington @ZackerySpytz
bpo-39050: The Help button in IDLE's config menu works again (GH-17611)
3b76188 
Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
(cherry picked from commit 2e43b64)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ZackerySpytz @terryjreedy @shihai1991
bpo-39050: The Help button in IDLE's config menu works again (pythonG…
d1e9b26 
…H-17611)

Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csabella csabella csabella left review comments

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

@terryjreedy terryjreedy

Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZackerySpytz @terryjreedy @csabella @miss-islington @bedevere-bot @the-knights-who-say-ni