Skip to content

[3.8] bpo-39310: Update sys.float_info documentation #17982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2020
Merged

[3.8] bpo-39310: Update sys.float_info documentation #17982

merged 1 commit into from
Jan 13, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 13, 2020 •
edited by bedevere-bot
Loading

Specify that sys.float_info.min is only the minimum normalized float.

https://bugs.python.org/issue39310

@vstinner
bpo-39310: Update sys.float_info documentation
dde0f6f 
Specify that sys.float_info.min is only the minimum normalized float.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jan 13, 2020
@vstinner vstinner requested a review from mdickinson January 13, 2020 11:48
@vstinner vstinner mentioned this pull request Jan 13, 2020
Merged
@vstinner
Copy link
Member Author

@mdickinson: I extracted the sys.float_info update from commit 0b2ab21. Would you mind to double check it?

I removed references to math.ulp() since this PR is for Python 3.8.

mdickinson
mdickinson approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; it's definitely an improvement on the existing documentation.

The wording for DBL_MAX_10_EXP is a bit vague and questionable (what does "in the range of representable finite floats" actually mean?), but that's not a problem introduced in this PR, and it's something that could be fixed separately.

@vstinner
Copy link
Member Author

The wording for DBL_MAX_10_EXP is a bit vague and questionable (what does "in the range of representable finite floats" actually mean?), but that's not a problem introduced in this PR, and it's something that could be fixed separately.

I have no idea how to explain it differently. So I let you propose another PR once this one is merged :-D

@vstinner vstinner merged commit 9362f85 into python:3.8 Jan 13, 2020
@vstinner vstinner deleted the float_info branch January 13, 2020 19:24
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 13, 2020
@vstinner @miss-islington
bpo-39310: Update sys.float_info documentation (pythonGH-17982)
8541c52 
Specify that sys.float_info.min is only the minimum normalized float.
(cherry picked from commit 9362f85)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-17994 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Jan 13, 2020
@miss-islington @vstinner
bpo-39310: Update sys.float_info documentation (GH-17982)
dfe159c 
Specify that sys.float_info.min is only the minimum normalized float.
(cherry picked from commit 9362f85)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @miss-islington @bedevere-bot @mdickinson @the-knights-who-say-ni