bpo-37751: Document the change in What's New in Python 3.9 #17997
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -439,6 +439,12 @@ Changes in the Python API | |||||
| :data:`~errno.EBADF` error. | ||||||
| (Contributed by Victor Stinner in :issue:`39239`.) | ||||||
|
|
||||||
| * :func:`codecs.lookup` now normalizes the encoding name the same way than | ||||||
|
There was a problem hiding this comment.
Suggested change
There was a problem hiding this comment. I create a new PR in #23096, and this word have been replaced. |
||||||
| :func:`encodings.normalize_encoding`, except that :func:`codecs.lookup` also | ||||||
| converts the name to lower case. For example, ``"latex+latin1"`` encoding | ||||||
| name is now normalized to ``"latex_latin1"``. | ||||||
| (Contributed by Jordon Xu in :issue:`37751`.) | ||||||
|
|
||||||
|
|
||||||
| CPython bytecode changes | ||||||
| ------------------------ | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other differences. For example,
normalize_encoding("КОИ-8")returns"кои_8", butcodecs.lookupnormalizes it to"8".The comment in the sources is also not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
encodings.normalize_encoding() says "Note that encoding names should be ASCII only." You're correct: "КОИ-8" is normalized to "8" by codecs.lookup() because the C function _Py_normalize_encoding() ignores non-ASCII letters.
I don't know which behavior is correct. It sounds strange to me to have a non-ASCII encoding name. Which encoding is supposed to be used to encoding the encoding name?!? :-D Maybe encodings.normalize_encoding() should also ignore non-ASCII letters, be more strict.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created bpo-39337: codecs.lookup() ignores non-ASCII characters, whereas encodings.normalize_encoding() copies them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the annotation of
normalize_encodinghave the words: Note that encoding names should be ASCII only.+1 for
encodings.normalize_encoding()should be similar as_Py_normalize_encoding().And I created a PR: #22219
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After #22219 merged, this problem have been fixed(MAYBE
enhancedwill be more exact).