Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39415: Remove unused codes from long/complex/floatobject.c #18105

Merged
merged 1 commit into from Jan 22, 2020
Merged

bpo-39415: Remove unused codes from long/complex/floatobject.c #18105

merged 1 commit into from Jan 22, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 21, 2020 •
edited

@corona10 corona10 changed the title bpo-39145: Remove unused codes from long/complex/floatobject.c bpo-39415: Remove unused codes from long/complex/floatobject.c Jan 21, 2020
mdickinson
mdickinson approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminp benjaminp added the needs backport to 3.8 only security fixes label Jan 22, 2020
@benjaminp benjaminp merged commit 0d5eac8 into python:master Jan 22, 2020
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2020
@corona10 @miss-islington
closes bpo-39415: Remove unused codes from longobject.c complexobject…
59dd0c2 
….c floatobject.c. (pythonGH-18105)

(cherry picked from commit 0d5eac8)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot
Copy link

GH-18112 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jan 22, 2020
@benjaminp benjaminp added the needs backport to 3.8 only security fixes label Jan 22, 2020
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18113 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2020
@corona10 @miss-islington
closes bpo-39415: Remove unused codes from longobject.c complexobject…
622ad6f 
….c floatobject.c. (pythonGH-18105)

(cherry picked from commit 0d5eac8)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Jan 22, 2020
miss-islington added a commit that referenced this pull request Jan 22, 2020
@miss-islington @corona10
closes bpo-39415: Remove unused codes from longobject.c complexobject…
a755410 
….c floatobject.c. (GH-18105)

(cherry picked from commit 0d5eac8)

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@corona10 @shihai1991
closes bpo-39415: Remove unused codes from longobject.c complexobject…
5c9cb50 
….c floatobject.c. (pythonGH-18105)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdickinson mdickinson mdickinson approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

@vstinner vstinner Awaiting requested review from vstinner

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@corona10 @miss-islington @bedevere-bot @mdickinson @benjaminp @the-knights-who-say-ni