Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-17050: Remove documentation on argparse.REMAINDER #18661

Merged
merged 1 commit into from
May 24, 2020
Merged

bpo-17050: Remove documentation on argparse.REMAINDER #18661

merged 1 commit into from
May 24, 2020

Conversation

corollari
Copy link
Contributor

@corollari corollari commented Feb 25, 2020 •
edited by miss-islington

Closes Issue 17050 by removing argparse.REMAINDER from the documentation, as discussed on the issue.

https://bugs.python.org/issue17050

Automerge-Triggered-By: @rhettinger

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@corollari

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 25, 2020
@corollari
Copy link
Contributor Author

I've already signed the CLA and I'm currently just waiting for it to get accepted.

Regarding the bedevere/news CI failure, I'm a bit confused by it because the docs on news blurbs states that "Changes that affect documentation only generally do not require a news entry.". Is there something I'm missing?

eamanu
eamanu approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@eamanu
Copy link
Contributor

eamanu commented Feb 26, 2020

@corollari yes you are right, this PR does not need a NEWs.

@csabella csabella requested a review from rhettinger May 22, 2020 20:05
@miss-islington
Copy link
Contributor

@corollari: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 59f5022 into python:master May 24, 2020
@miss-islington
Copy link
Contributor

Thanks @corollari for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-20363 is a backport of this pull request to the 3.9 branch.

rhettinger pushed a commit that referenced this pull request May 24, 2020
@miss-islington
bpo-17050: Remove documentation on argparse.REMAINDER (GH-18661) (GH-…
46c1b9c 
…20363)
@sobolevn sobolevn mentioned this pull request Apr 17, 2023
Merged
@hauntsaninja hauntsaninja mentioned this pull request Apr 19, 2023
Open
@mihaic mihaic mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger rhettinger approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@corollari @the-knights-who-say-ni @eamanu @miss-islington @bedevere-bot @rhettinger