Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-40024: Update xxxxmodule to use PyModule_AddType. #19119

Merged
merged 16 commits into from Mar 24, 2020

Conversation

@corona10
Copy link
Member

corona10 commented Mar 23, 2020

Modules/_datetimemodule.c Outdated Show resolved Hide resolved
Modules/_datetimemodule.c Outdated Show resolved Hide resolved
@dimaqq
dimaqq approved these changes Mar 24, 2020
@corona10 corona10 changed the title bpo-40024: Update xxxxmodule to use PyModule_AddType. [WIP] bpo-40024: Update xxxxmodule to use PyModule_AddType. Mar 24, 2020
@corona10 corona10 force-pushed the corona10:bpo-40024-part2 branch from 58580d9 to f648d8e Mar 24, 2020
@corona10 corona10 removed the DO-NOT-MERGE label Mar 24, 2020
@corona10 corona10 changed the title [WIP] bpo-40024: Update xxxxmodule to use PyModule_AddType. bpo-40024: Update xxxxmodule to use PyModule_AddType. Mar 24, 2020
@corona10 corona10 requested a review from pganssle Mar 24, 2020
@corona10

This comment has been minimized.

Copy link
Member Author

corona10 commented Mar 24, 2020

@vstinner @pganssle Please take a look :)

Copy link
Member

vstinner left a comment

weakref_exec() of Modules/_weakref.c would also benefit of PyModule_AddType().

Modules/_io/_iomodule.c Show resolved Hide resolved
Modules/_asynciomodule.c Show resolved Hide resolved
Modules/_cursesmodule.c Outdated Show resolved Hide resolved
@corona10 corona10 force-pushed the corona10:bpo-40024-part2 branch from 84631d3 to 95ea687 Mar 24, 2020
@corona10

This comment has been minimized.

Copy link
Member Author

corona10 commented Mar 24, 2020

@vstinner Updated! Please take a look.

@corona10

This comment has been minimized.

Copy link
Member Author

corona10 commented Mar 24, 2020

@vstinner Updated!

@corona10 corona10 force-pushed the corona10:bpo-40024-part2 branch from c129ffa to ff64806 Mar 24, 2020
@vstinner vstinner merged commit 37fcbb6 into python:master Mar 24, 2020
12 checks passed
12 checks passed
Windows (x86)
Details
Windows (x86)
Details
Windows (x64)
Details
Windows (x64)
Details
macOS
Details
macOS
Details
Ubuntu
Details
Ubuntu
Details
Azure Pipelines PR #20200324.41 succeeded
Details
bedevere/issue-number Issue number 40024 found
Details
bedevere/news "skip news" label found
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vstinner

This comment has been minimized.

Copy link
Member

vstinner commented Mar 24, 2020

Thanks @corona10, I merged your PR.

@corona10 corona10 deleted the corona10:bpo-40024-part2 branch Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.