Skip to content

bpo-40334: Don't skip test_parser:test_trigger_memory_error #19744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

lysnikolaou
Copy link
Member

@lysnikolaou lysnikolaou commented Apr 27, 2020

This test has been changed to always use the old parser, so no need
for it to be skipped.

https://bugs.python.org/issue40334

This test has been changed to always use the old parser, so no need
for it to be skipped.
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Why doesn't pegen trigger? Because it goes up to 200?)

@lysnikolaou
Copy link
Member Author

(Why doesn't pegen trigger? Because it goes up to 200?)

Yes, and that's because the tokenizer enforces that restriction. The old parser was throwing a MemoryError way before that.

@lysnikolaou lysnikolaou changed the title bpo-40334: Don't skip test_parser:test_trigget_memory_error bpo-40334: Don't skip test_parser:test_trigger_memory_error Apr 27, 2020
@pablogsal pablogsal merged commit 3d53d87 into python:master Apr 28, 2020
@lysnikolaou lysnikolaou deleted the fix-test-parser branch May 8, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants