Skip to content

bpo-40432 Fix MSBuild project for Pegen grammars #19785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

tonybaloney
Copy link
Contributor

@tonybaloney tonybaloney commented Apr 29, 2020

The additional tasks in the MSBuild project for pegen regeneration are not functional:

  • Setting PYTHONPATH= inline cannot be done in Windows using that method
  • The task does not inherit environment variables that way
  • The path to the peg_generator module is in Unix path format

Cc @pablogsal

https://bugs.python.org/issue40432

@tonybaloney tonybaloney requested a review from a team as a code owner April 29, 2020 02:38
@tonybaloney
Copy link
Contributor Author

before

c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(175,5): error MSB3073: The command ""c:\Users\anthonysh
aw\source\repos\cpython\PCbuild\win32\python.exe" -m pegen -q c "c:\Users\anthonyshaw\source\repos\cpython\Grammar\pyth
on.gram" "c:\Users\anthonyshaw\source\repos\cpython\Grammar\Tokens" -o "c:\Users\anthonyshaw\source\repos\cpython\PCbui
ld\obj\39win32_Release\regen\parse.c"" exited with code 1.

After

Build succeeded.

c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(167,5): warning : Grammar updated. You will need to reb
uild pythoncore to see the changes.
c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(184,5): warning : Python-ast.h updated. You will need t
o rebuild pythoncore to see the changes.
c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(192,5): warning : Python-ast.c updated. You will need t
o rebuild pythoncore to see the changes.
c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(200,5): warning : Opcodes updated. You will need to reb
uild pythoncore to see the changes.
c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(218,5): warning : Keywords updated. You will need to re
build pythoncore to see the changes.
c:\Users\anthonyshaw\source\repos\cpython\PCbuild\regen.vcxproj(176,5): warning : Pegen updated. You will need to rebui
ld pythoncore to see the changes.
    6 Warning(s)
    0 Error(s)

Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Thanks for checking and the quick fix @tonybaloney ! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants